abstractdog commented on code in PR #461:
URL: https://github.com/apache/tez/pull/461#discussion_r2895542983
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -2431,18 +2426,23 @@ public static void main(String[] args) {
Configuration conf = new Configuration();
- AMExtensions amExtensions = getFrameworkService(conf).getAMExtensions();
+ ServerFrameworkService frameworkService = getFrameworkService(conf);
+ AMExtensions amExtensions = frameworkService.getAMExtensions();
DAGProtos.ConfigurationProto confProto =
amExtensions.loadConfigurationProto();
TezUtilsInternal.addUserSpecifiedTezConfiguration(conf,
confProto.getConfKeyValuesList());
+ NodeContext nodeContext =
+ (frameworkService instanceof YarnServerFrameworkService)
+ ? new YarnNodeManagerContext()
+ : null;
Review Comment:
I think instead of an `instanceof` check we should let
`ServerFrameworkService` interface handle this: the advantage of separate
framework service implementations is to eliminate these type checks (the
`ZkStandaloneServerFrameworkService` can simply return null or a
`LocalNodeContext` with dummy values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
