abstractdog commented on code in PR #461:
URL: https://github.com/apache/tez/pull/461#discussion_r2884162869
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -1207,15 +1208,15 @@ public ContainerId getAppContainerId() {
}
public String getAppNMHost() {
- return nmHost;
+ return nodeContext.getNodeHostString();
}
public int getAppNMPort() {
- return nmPort;
+ return nodeContext.getNodePort();
}
public int getAppNMHttpPort() {
- return nmHttpPort;
+ return nodeContext.getNodeHttpPort();
Review Comment:
code hygiene patches are always welcome
IMO you can remove these methods here, and do more in separate PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
