abstractdog commented on PR #505:
URL: https://github.com/apache/tez/pull/505#issuecomment-4610751277

   > * Drop Hadoop 2.x Support by eliminate Hadoop Shim Layer
   > * Moved the Hadoop 2.8+ shims logic to TezUtilsInternal.java.
   > * Removed hadoop27, hadoop28 profiles
   > * Removed GuavaShim layer as well which was pre v18.0 of guava.
   
   thanks for the patch @Aggarwal-Raghav so far!
   dropping the whole shim looks strange for me, I thought this is only for 
dropping hadoop 2.x, but shims are more generic way to handle different hadoop 
versions, which can be useful in the future too, right? please let me know if I 
miss something
   
   the same applies to GuavaShim: it was related to incompatible Guava 
versions, and I'm afraid removing it can make extra work in the future if we 
find ourselves in a similar situation...but regardless, removing it should be a 
scope of a different ticket
   
   this one can focus on dropping hadoop 2.x support only, and we can make it 
happen quite easily


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to