Aggarwal-Raghav commented on PR #505: URL: https://github.com/apache/tez/pull/505#issuecomment-4610895592
> > * Drop Hadoop 2.x Support by eliminate Hadoop Shim Layer > > * Moved the Hadoop 2.8+ shims logic to TezUtilsInternal.java. > > * Removed hadoop27, hadoop28 profiles > > * Removed GuavaShim layer as well which was pre v18.0 of guava. > > thanks for the patch @Aggarwal-Raghav so far! dropping the whole shim looks strange for me, I thought this is only for dropping hadoop 2.x, but shims are more generic way to handle different hadoop versions, which can be useful in the future too, right? please let me know if I miss something > > the same applies to GuavaShim: it was related to incompatible Guava versions, and I'm afraid removing it can make extra work in the future if we find ourselves in a similar situation...but regardless, removing it should be a scope of a different ticket > > this one can focus on dropping hadoop 2.x support only, and we can make it happen quite easily I thought about it before dropping the shims framework, I considered the potential for future incompatibility scenarios. These include the incompatibility between Hadoop3.x and Hadoop 4.x (in the future maybe). But these scenario are speculative and its better to avoid the maintenance of two versions of the hadoop or guava. It is preferable to support the latest version at the present time. We had Hadoop27 profile but if you try to run on master it is not even running becuase of self-referene in 1 of the pom.xml. Another instance is that hadoop2.x is jdk8 but now its jdk21. I hightly doubt even with shims present the JVM 8 and JDK 21 JVM cross-compatiblity will work. But if you think its better to retain shims framework confirm once. I have expressed my thoughts but I don't have the final say here 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
