maheshrajus commented on code in PR #474:
URL: https://github.com/apache/tez/pull/474#discussion_r3381535556


##########
tez-api/src/test/java/org/apache/tez/dag/api/client/TestTimelineReaderFactory.java:
##########
@@ -52,10 +52,10 @@ public void 
testPseudoAuthenticatorConnectionUrlShouldHaveUserName() throws Exce
     ConnectionConfigurator connConf = mock(ConnectionConfigurator.class);
     
TimelineReaderPseudoAuthenticatedStrategy.PseudoAuthenticatedURLConnectionFactory
         connectionFactory = new TimelineReaderPseudoAuthenticatedStrategy
-          .PseudoAuthenticatedURLConnectionFactory(connConf);
+        .PseudoAuthenticatedURLConnectionFactory(connConf);
     String inputUrl = "http://host:8080/path";;
     String expectedUrl = inputUrl + "?user.name=" + 
UserGroupInformation.getCurrentUser().getShortUserName();
-    HttpURLConnection httpURLConnection = 
connectionFactory.getHttpURLConnection(new URL(inputUrl));
+    HttpURLConnection httpURLConnection = 
connectionFactory.getConnection(URI.create(inputUrl).toURL());

Review Comment:
   @abstractdog I created https://issues.apache.org/jira/browse/TEZ-4726 for 
handling rest of the code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to