abstractdog commented on PR #474:
URL: https://github.com/apache/tez/pull/474#issuecomment-4668413415
> @abstractdog Look like the checkstyle task is catching incorrect one here.
'If' child has Indentation level 2. In this line i have not added any spaces
except entityID string. Anything i am missing over here ?
>
>
./tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/SimpleHistoryParser.java:258:
userName = subEntity.getString(Constants.ENTITY_ID);:15: 'if' child has
incorrect indentation level 14, expected level should be 16. [Indentation]
>
> Code:
>
> ```
> if (subEntityType != null &&
subEntityType.equals(Constants.USER)) {
> userName = subEntity.getString(Constants.ENTITY_ID);
> break;
> }
> ```
>
> Link:
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-474/13/artifact/out/results-checkstyle-root.txt
we can ignore that checkstyle warning then, for me it's clearly a bug in
checkstyle
we use 2 spaces, and it applies to branches of if/else too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
