abstractdog commented on PR #514: URL: https://github.com/apache/tez/pull/514#issuecomment-4843596629
thanks for this patch @maheshrajus, a few notes: 1. after removing phantomjs, we can try to build tez-ui also on arm64: https://github.com/apache/tez/blob/17d15490cedab7d18a4d4c1f83374e30c58a363f/.github/workflows/build.yml#L53 2. checked out pr, ran `mvn clean install` in tez-ui and I saw a browser window running the tests: <img width="1004" height="542" alt="Screenshot 2026-06-30 at 14 40 40" src="https://github.com/user-attachments/assets/bccd16c4-c5f5-475e-920d-fe48800c952f"; /> while it was awesome to see, I'm expecting a headless browser to not display at all, does it make sense? 3. after install, I got this diff: ``` -"moment@>= 2.29.4": - version "2.29.4" - resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"; +"moment@>= 2.6.0": + version "2.30.1" + resolved "https://registry.yarnpkg.com/moment/-/moment-2.30.1.tgz#f8c91c07b7a786e30c59926df530b4eac96974ae"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
