abstractdog commented on PR #514: URL: https://github.com/apache/tez/pull/514#issuecomment-4881503633
> @abstractdog I fixed your review comments and verified locally + in yetus CI env. Could you please review the PR at your convenience? Thank you ! looks good so far, I have only one concern: on a vanilla ubuntu server, when chromium wasn't installed, the build simply failed by: ``` Building..Built project successfully. Stored in "/home/abstractdog/apache/tez/tez-ui/src/main/webapp/tmp/class-tests_dist-NhEe6O0O.tmp". not ok 1 Chrome - Browser "scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type <url>" exited unexpectedly. ``` if the build process cannot take care of fetching a chrome or chromium, then a preinstalled chrome is a hard dependency of a `mvn clean install` command, which doesn't sound to good to me could the build process take care of the same automatically? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
