Aggarwal-Raghav commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5015411114

   @abstractdog , I verified that the `?method=` parameter was maping to the 
`-e` flag and successfully generates FlameGraphs for that method in the 
async-profiler 4.4 i.e. latest
   
   As per async-profiler readme:
   
https://github.com/async-profiler/async-profiler/blob/master/docs/ProfilingModes.md#java-method-profiling
   > -e ClassName.methodName option instruments the given Java method in order 
to record all invocations of this method with the stack traces.
   
   **I have a question, do we want to stop this method level profiling if yes 
then this PR is correct otherwise,
   Do you want to keep the feature, cancel TEZ-4740, and just fix the comment 
typo from -m to -e flag?**
    
   **BEFORE:**
   <img width="1512" height="263" alt="Screenshot 2026-07-19 at 3 27 53 PM" 
src="https://github.com/user-attachments/assets/ad3473cf-01d3-432c-adb1-1e3944ab1ada";
 />
   
   <img width="1512" height="247" alt="Screenshot 2026-07-19 at 3 28 13 PM" 
src="https://github.com/user-attachments/assets/f84efbc4-cc0b-441c-a25e-004c18306f94";
 />
   
   **AFTER:**
   <img width="1507" height="170" alt="Screenshot 2026-07-19 at 3 58 00 PM" 
src="https://github.com/user-attachments/assets/2f4e8cd0-6a10-48c4-978a-094d77a9d164";
 />
   
   <img width="793" height="328" alt="Screenshot 2026-07-19 at 4 00 16 PM" 
src="https://github.com/user-attachments/assets/5c4226e3-7413-4fb3-9850-b79770ad4c12";
 />


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to