abstractdog commented on PR #525: URL: https://github.com/apache/tez/pull/525#issuecomment-5021160948
> > > fix the comment typo from -m to -e flag > > > > > > thanks @Aggarwal-Raghav for investigating this: I was worried that maybe async profiler dropped the support of profiling methods, however, if it works with the `-e`, we can simply fix the typo definitely! the goal is to be very clear about the fact that in newer async profiler versions, method profiling is possible via the `-e` option feel free to rename Jira accordingly > > i think older also it was `-e` since 2.0 https://github.com/async-profiler/async-profiler/blob/v2.0/README.md#java-method-profiling > > So, now I'll rename this ticket to update the javadoc only and update the path to only support for 4.4 and drop support for 3.x? > > https://github.com/apache/tez/blob/b9d8c0f37b3c3fdc17d2c007297b3b559bd468a4/tez-common/src/main/java/org/apache/tez/common/web/ProfileServlet.java#L306-L314 I think dropping profile 3.x support is another thing to discuss, I'm fine with not doing it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
