abstractdog commented on PR #514: URL: https://github.com/apache/tez/pull/514#issuecomment-5031876285
> @abstractdog Could you please review the PR at your convenience? Thank you ! thanks @maheshrajus , tried it on a vanilla ubuntu, and doesn't seem to work as I expect, let me share what I can see and maybe you can tell if I miss something: 1. run `mvn clean install` in tez-ui, the doc says `"yarn install" (run automatically by Maven)` takes care of that 2. I get an error like: ``` Building...Built project successfully. Stored in "/home/abstractdog/apache/tez/tez-ui/src/main/webapp/tmp/class-tests_dist-oQZlTw0S.tmp". not ok 1 Chrome - Browser "scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type <url>" exited unexpectedly. 1..1 # tests 1 # pass 0 # fail 1 error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ``` 3. running it manually: empty response, not even an echo I would expect ``` abstractdog@ubuntu-8gb-hel1-3:~/apache/tez/tez-ui$ ./src/main/webapp/scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors "fake" abstractdog@ubuntu-8gb-hel1-3:~/apache/tez/tez-ui$ echo $? 127 ``` so I'm not sure anymore if mvn install automatically takes care of yarn insall, or I have to do it, becuase even if I saw the echo message, it would tell "Alternatively, run 'yarn install' inside src/main/webapp to let puppeteer download Chromium automatically.", but doc says "# "yarn install" (run automatically by Maven) will download a bundled # Chromium, so the build works on a vanilla machine with no pre-installed" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
