maheshrajus commented on code in PR #520:
URL: https://github.com/apache/tez/pull/520#discussion_r3659593793
##########
tez-tests/src/test/java/org/apache/tez/test/TestAMRecoveryAggregationBroadcast.java:
##########
@@ -339,12 +349,20 @@ private DAG createDAG(String dagName) throws Exception {
return dag;
}
- TezCounters runDAGAndVerify(DAG dag, boolean killAM) throws Exception {
+ TezCounters runDAGAndVerify(DAG dag, boolean killAM,
+ List<String> vertexNamesToWaitFor) throws Exception {
tezSession.waitTillReady();
DAGClient dagClient = tezSession.submitDAG(dag);
if (killAM) {
- TimeUnit.SECONDS.sleep(10);
+ // Deterministic wait: block until every named upstream vertex reaches
+ // SUCCEEDED. Replaces a fixed Thread.sleep(10s) which was too short on
+ // slow CI machines and caused the recovery-log assertions below to
+ // fail intermittently.
+ for (String vertexName : vertexNamesToWaitFor) {
+ waitForVertexSucceeded(dagClient, vertexName,
+ TimeUnit.SECONDS.toMillis(60));
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
