abstractdog commented on code in PR #520:
URL: https://github.com/apache/tez/pull/520#discussion_r3673313357
##########
tez-tests/src/test/java/org/apache/tez/test/TestAMRecoveryAggregationBroadcast.java:
##########
@@ -356,14 +369,41 @@ TezCounters runDAGAndVerify(DAG dag, boolean killAM)
throws Exception {
LOG.info("Diagnosis: " + dagStatus.getDiagnostics());
assertEquals(State.SUCCEEDED, dagStatus.getState());
- FSDataInputStream in = remoteFs.open(new Path(OUT_PATH,
"part-v002-o000-r-00000"));
+ FSDataInputStream in = remoteFs.open(new Path(outPath,
"part-v002-o000-r-00000"));
ByteBuffer buf = ByteBuffer.allocate(100);
in.read(buf);
buf.flip();
assertEquals(EXPECTED_OUTPUT,
StandardCharsets.UTF_8.decode(buf).toString());
return dagStatus.getDAGCounters();
}
+ private void waitForVertexSucceeded(DAGClient dagClient, String vertexName,
Review Comment:
this method looks quite common, maybe similarly to TEZ-4744, it can be
refactored and reused somewhere in tez-api as a util (in a follow-up ticket):
it's useful, not only in testing time, but even for tez client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
