Aggarwal-Raghav commented on code in PR #530:
URL: https://github.com/apache/tez/pull/530#discussion_r3731039550
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/FetcherOrderedGrouped.java:
##########
@@ -151,6 +155,7 @@ public FetcherOrderedGrouped(HttpConnectionParams
httpConnectionParams,
this.badIdErrs = badIdErrsCounter;
this.connectionErrs = connectionErrsCounter;
this.wrongReduceErrs = wrongReduceErrsCounter;
+ this.ioTimeCounter =
inputContext.getCounters().findCounter(TaskCounter.SHUFFLE_IO_TIME_MILLISECONDS);
Review Comment:
1 thing to call out is even `tez.runtime.shuffle.measure.io.time=false` the
counter will have `SHUFFLE_IO_TIME_MILLISECONDS: 0` to prevent this the
following is required or we can have it but might be misleading looking at the
counter stats..
```java
this.ioTimeCounter =
conf.getBoolean(TezRuntimeConfiguration.TEZ_RUNTIME_SHUFFLE_MEASURE_IO_TIME,
TezRuntimeConfiguration.TEZ_RUNTIME_SHUFFLE_MEASURE_IO_TIME_DEFAULT)
?
inputContext.getCounters().findCounter(TaskCounter.SHUFFLE_IO_TIME_MILLISECONDS)
: null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
