abstractdog commented on code in PR #530:
URL: https://github.com/apache/tez/pull/530#discussion_r3797959881
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/FetcherOrderedGrouped.java:
##########
@@ -227,6 +238,10 @@ private void cleanupCurrentConnection(boolean disconnect) {
synchronized (cleanupLock) {
try {
if (httpConnection != null) {
+ if (input instanceof MeasuredDataInputStream && ioTimeCounter !=
null) {
Review Comment:
nit: maybe evaluate "ioTimeCounter != null" first, looks more efficient than
an `instanceof` check
also, is the `instanceof` check needed at all? by design, ioTimeCounter is
non-null, if and only if measurement is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
