rob05c commented on a change in pull request #3023: WIP Supported routes fetch URL: https://github.com/apache/trafficcontrol/pull/3023#discussion_r233122041
########## File path: traffic_ops/traffic_ops_golang/api/api_route.go ########## @@ -0,0 +1,148 @@ +package api Review comment: The `api` package is for API handler things, not routing/dispatch. I agree this should be moved, but I think it should have its own package, `routing`. It would also be ideal if the move were in its own PR, just to make them simpler and easier to review. We should also avoid putting underscores in Go filenames. Yes, we have a lot already; we need to fix them. Go reserves underscore suffixes for compiler-specific uses, like tests and architectures, e.g. `_test.go`, `_darwin.go`. Non-directive underscore suffixes should be avoided, to prevent potentially breaking in the future, if the Go language were to add new directives. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
