rob05c commented on a change in pull request #3023: WIP Supported routes fetch
URL: https://github.com/apache/trafficcontrol/pull/3023#discussion_r233219875
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/traffic_ops_golang.go
 ##########
 @@ -46,6 +46,9 @@ import (
 // set the version at build time: `go build -X "main.version=..."`
 var version = "development"
 
+// Traffic Ops version, set before building
+const Version = "3.0.0"
 
 Review comment:
   `version` only reads `development` in development. The `build.sh` sets it to 
the real version: 
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/build/traffic_ops.spec#L114
   
   The overall Traffic Control version is maintained in 
https://github.com/apache/trafficcontrol/blob/master/VERSION - we don't want 
that in multiple places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to