rob05c commented on a change in pull request #3023: WIP Supported routes fetch URL: https://github.com/apache/trafficcontrol/pull/3023#discussion_r233240205
########## File path: traffic_ops/traffic_ops_golang/traffic_ops_golang.go ########## @@ -46,6 +46,9 @@ import ( // set the version at build time: `go build -X "main.version=..."` var version = "development" +// Traffic Ops version, set before building +const Version = "3.0.0" Review comment: >Is there really no way to get the go toolchain to set that without explicitly passing it on the command line? Sort of. You could use a `go generate` tag, but that's still an additional build step. Not really worth the complexity for this one tiny use case. > a Makefile for a Go project doesn't make sense because go does everything make would do. But it doesn't. Again, there's `go generate`, but that's a separate command, which is an argument for using Make to `go generate; go build`. Makefiles for Go projects do make sense. I don't think it's worth the cost here; but there are use cases for it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
