rawlinp commented on a change in pull request #3177: Added warning SQL query 
for duplicated origins
URL: https://github.com/apache/trafficcontrol/pull/3177#discussion_r245378793
 
 

 ##########
 File path: traffic_ops/app/db/admin.pl
 ##########
 @@ -64,7 +64,7 @@
        . "dropdb  - Execute db 'dropdb' on the database for the current 
environment.\n"
 
 Review comment:
   If we want to take this even further I was just thinking of having the 
admin.pl script shell out all of its individual commands to the binary. So the 
admin.pl script would just be a tiny perl script that basically only does 
something like this:
   ```
   my $new_admin = dirname(__FILE__) + "/admin";
   shift @ARGV;
   my $args = join " ", @ARGV;
   system("$new_admin $args");
   ```
   We could probably even just convert it into a bash script still named 
admin.pl, but I'd be concerned about the possible confusion with that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to