rawlinp commented on a change in pull request #3177: Added warning SQL query
for duplicated origins
URL: https://github.com/apache/trafficcontrol/pull/3177#discussion_r245413648
##########
File path: traffic_ops/app/db/admin.pl
##########
@@ -64,7 +64,7 @@
. "dropdb - Execute db 'dropdb' on the database for the current
environment.\n"
Review comment:
> I like the idea of using the binary for everything, but I don't think it
belongs in the same commit as added functionality.
+1, would be better to review and merge the PR that makes admin.pl shell
everything out to the binary first. Then the new functionality can just be
reviewed in admin.go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
