mitchell852 commented on a change in pull request #3584: adds more automated TP
tests so the data can build from a clean db
URL: https://github.com/apache/trafficcontrol/pull/3584#discussion_r286217294
##########
File path:
traffic_portal/app/src/common/modules/table/cacheGroups/table.cacheGroups.tpl.html
##########
@@ -23,7 +23,7 @@
<li class="active">Cache Groups</li>
</ol>
<div class="pull-right" role="group" ng-if="!settings.isNew">
- <button class="btn btn-primary" title="Create Cache Group"
ng-click="createCacheGroup()"><i class="fa fa-plus"></i></button>
+ <button name="createCacheGroupButton" class="btn btn-primary"
title="Create Cache Group" ng-click="createCacheGroup()"><i class="fa
fa-plus"></i></button>
Review comment:
yeah, i agree. if you want to have a "tp best practices" issues and list out
stuff like "correct button types, fors on labels, presentation vs. content,
etc". i think that would be great. we could also slap the "good first issue"
label on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
