mitchell852 commented on a change in pull request #3584: adds more automated TP 
tests so the data can build from a clean db
URL: https://github.com/apache/trafficcontrol/pull/3584#discussion_r286235414
 
 

 ##########
 File path: traffic_portal/test/end_to_end/common/commonFunctions.js
 ##########
 @@ -31,4 +31,17 @@ module.exports = function() {
        this.urlPath = function ( url ) {
                return '/' + String(url).split('/').slice(3).join('/');
        };
+
+       this.shuffle = function (string) {
+               var a = string.split(""),
+                       n = a.length;
+
+               for(var i = n - 1; i > 0; i--) {
 
 Review comment:
   this is not my area of expertise. the first one was a stackoverflow special.
   
   yours is giving me weird output (commas):
   
   commonFunctions.shuffle('abcdefghijklmonpqrstuvwxyz')
   => a,b,c,r,d,e,f,o,x,u,m,g,z,h,i,n,j,l,p,k,s,q,v,w,y,t
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to