alficles commented on a change in pull request #3875: Add TO Go ATS CDN configs URL: https://github.com/apache/trafficcontrol/pull/3875#discussion_r318810611
########## File path: lib/go-atscfg/regexremapdotconfig.go ########## @@ -0,0 +1,58 @@ +package atscfg + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import ( + "strings" + + "github.com/apache/trafficcontrol/lib/go-tc" +) + +type CDNDS struct { + OrgServerFQDN string + QStringIgnore int + CacheURL string + RegexRemap string +} + +func MakeRegexRemapDotConfig( + cdnName tc.CDNName, + toToolName string, // tm.toolname global parameter (TODO: cache itself?) + toURL string, // tm.url global parameter (TODO: cache itself?) + fileName string, + dses map[tc.DeliveryServiceName]CDNDS, +) string { + text := GenericHeaderComment(string(cdnName), toToolName, toURL) + + if len(fileName) < len(`regex_remap_.config`) { + return text // TODO warn? Perl doesn't + } + + dsName := fileName[len("regex_remap_") : len(fileName)-len(".config")] Review comment: I've seen this set of code a number of times now. This could definitely be a function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
