alficles commented on a change in pull request #3875: Add TO Go ATS CDN configs URL: https://github.com/apache/trafficcontrol/pull/3875#discussion_r318816610
########## File path: lib/go-atscfg/sslmulticertdotconfig.go ########## @@ -0,0 +1,74 @@ +package atscfg + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import ( + "strings" + + "github.com/apache/trafficcontrol/lib/go-log" + "github.com/apache/trafficcontrol/lib/go-tc" +) + +type SSLMultiCertDS struct { + Type tc.DSType + Protocol int + ExampleURLs []string +} + +func MakeSSLMultiCertDotConfig( + cdnName tc.CDNName, + toToolName string, // tm.toolname global parameter (TODO: cache itself?) + toURL string, // tm.url global parameter (TODO: cache itself?) + dses map[tc.DeliveryServiceName]SSLMultiCertDS, +) string { + text := GenericHeaderComment(string(cdnName), toToolName, toURL) + + for dsName, ds := range dses { + if ds.Type.IsSteering() { + continue // Steering delivery service SSLs should not be on the edges. + } + if ds.Protocol == 0 { + continue + } + if len(ds.ExampleURLs) == 0 { + continue // TODO warn? error? Perl doesn't + } + + hostName := ds.ExampleURLs[0] // first one is the one we want + + scheme := "https://"; + if !strings.HasPrefix(hostName, scheme) { + scheme = "http://"; + } Review comment: This clearly does the wrong thing if the scheme is anything other than `https?`. I'm pretty sure that can't happen right now, but if somebody adds `gopher://` in the future, this is going to fail in really weird ways. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
