ocket8888 commented on a change in pull request #3758: Rewrote deliveryservice_stats to Go URL: https://github.com/apache/trafficcontrol/pull/3758#discussion_r328804291
########## File path: traffic_ops/traffic_ops_golang/trafficstats/trafficstats.go ########## @@ -0,0 +1,691 @@ +package trafficstats Review comment: I could write some negative tests for the format of the request, but I don't handle user permissions in the route handler, and a unit test can't handle a connection to an external InfluxDB server; that's an integration test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
