ocket8888 commented on a change in pull request #3758: Rewrote
deliveryservice_stats to Go
URL: https://github.com/apache/trafficcontrol/pull/3758#discussion_r329166666
##########
File path: traffic_ops/traffic_ops_golang/api/api.go
##########
@@ -369,6 +382,78 @@ func (inf *APIInfo) Close() {
}
}
+// CreateInfluxClient onstructs and returns an InfluxDB HTTP client, if
enabled and when possible.
+// The error this returns should not be exposed to the user; it's for logging
purposes only.
+//
+// If Influx connections are not enabled, this will return `nil` - but also no
error. It is expected
+// that the caller will handle this situation appropriately.
+func (inf *APIInfo) CreateInfluxClient() (c *influx.Client, e error) {
+ if !inf.Config.InfluxEnabled {
+ return
+ }
+
+ var fqdn string
+ var TCPPort uint
Review comment:
I'll change it because I don't really care that much - though for my money
"url" is nonsense that doesn't mean anything while "URL" stands for something -
but I don't think it's fair to require a convention not agreed-upon by or
enforced mechanically by the project. If local variables should start with a
lowercase letters, there should be a linter configuration introduced to the
repository and approved on the mailing list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
