ocket8888 commented on a change in pull request #3947: Rewrite get federation
deliveryservices to Go
URL: https://github.com/apache/trafficcontrol/pull/3947#discussion_r331153392
##########
File path: traffic_ops/testing/api/v14/federations_test.go
##########
@@ -93,4 +93,16 @@ func PostTestFederationsDeliveryServices(t *testing.T) {
if _, err = TOSession.CreateFederationDeliveryServices(fedID,
[]int{ds.ID}, true); err != nil {
t.Errorf("creating federations delivery services: %v\n", err)
}
+
+ // Test get created Federation Delivery Service
+ fedDSes, _, err := TOSession.GetFederationDeliveryServices(fedID)
+ if err != nil {
+ t.Errorf("cannot GET Federation DeliveryServices: %v\n", err)
Review comment:
Should be a `t.Fatalf` - the caller can't safely assume that `fedDSes` in
this case isn't `nil`.
I know that the way you wrote that this isn't exactly possible, but in
general it's true. I guess I don't really have a problem with that, provided
the GoDoc notes that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
