ocket8888 commented on a change in pull request #3947: Rewrite get federation
deliveryservices to Go
URL: https://github.com/apache/trafficcontrol/pull/3947#discussion_r331152804
##########
File path: traffic_ops/client/federation.go
##########
@@ -78,3 +79,12 @@ func (to *Session)
CreateFederationDeliveryServices(federationID int, deliverySe
inf, err := makeReq(to, http.MethodPost,
apiBase+`/federations/`+strconv.Itoa(federationID)+`/deliveryservices`,
jsonReq, &resp)
return inf, err
}
+
+func (to *Session) GetFederationDeliveryServices(federationID int)
([]tc.FederationDeliveryServiceNullable, ReqInf, error) {
Review comment:
Client functions should have GoDocs IMO. Not as big a deal on other things,
but this is directly exposed as a part of an interface to our system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
