mhoppa commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337106370
########## File path: traffic_ops/testing/api/v14/deliveryservice_server_capabilities_test.go ########## @@ -0,0 +1,211 @@ +package v14 + +/* + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +import ( + "fmt" + "strings" + "testing" + + "github.com/apache/trafficcontrol/lib/go-tc" + "github.com/apache/trafficcontrol/lib/go-util" +) + +func TestGetDeliveryServiceServerCapabilities(t *testing.T) { + WithObjs(t, []TCObj{CDNs, Types, Tenants, Users, Parameters, Profiles, Statuses, Divisions, Regions, PhysLocations, CacheGroups, Servers, ServerCapabilities, DeliveryServices, DeliveryServiceServerCapabilities}, func() { + testCases := []struct { + description string + capability tc.DeliveryServiceServerCapability + expected int + err string + }{ + { + description: "get all deliveryservice server capabilities", + expected: len(testData.DeliveryServiceServerCapabilities), + }, + { + description: fmt.Sprintf("get all deliveryservice server capabilities by delivery service id"), Review comment: nit but no need for `fmt.Sprintf` for any of the descriptions ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
