mhoppa commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337105898
########## File path: traffic_ops/client/deliveryservice_server_capabilities.go ########## @@ -0,0 +1,79 @@ +/* + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package client + +import ( + "encoding/json" + "fmt" + "net" + "net/url" + "strconv" + + "github.com/apache/trafficcontrol/lib/go-tc" +) + +const ( + v14DeliveryServiceServerCapabilities = apiBase + "/deliveryservice_server_capabilities" +) + +// CreateDeliveryServiceServerCapability assigns a Server Capability to a Delivery Service +func (to *Session) CreateDeliveryServiceServerCapability(capability tc.DeliveryServiceServerCapability) (tc.Alerts, ReqInf, error) { + var alerts tc.Alerts + var remoteAddr net.Addr + reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: remoteAddr} + reqBody, err := json.Marshal(capability) + if err != nil { + return tc.Alerts{}, reqInf, err + } + reqInf, err = post(to, v14DeliveryServiceServerCapabilities, reqBody, &alerts) + return alerts, reqInf, err +} + +// DeleteDeliveryServiceServerCapability unassigns a Server Capability from a Delivery Service +func (to *Session) DeleteDeliveryServiceServerCapability(deliveryserviceID int, serverCapability string) (tc.Alerts, ReqInf, error) { + var alerts tc.Alerts + endpoint := fmt.Sprintf("%v?deliveryServiceID=%v&serverCapability=%v", v14DeliveryServiceServerCapabilities, deliveryserviceID, serverCapability) Review comment: Since you used url.Values on get lets do that here as well for the query parameters ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
