ocket8888 commented on a change in pull request #4390: Remove methods marked as deprecated in 3.x URL: https://github.com/apache/trafficcontrol/pull/4390#discussion_r377323783
########## File path: grove/grovetccfg/grovetccfg.go ########## @@ -361,7 +361,7 @@ func createGroveCfg(toc *to.Session, server tc.Server) (bool, config.Config, err } } - serverParameters, err := toc.Parameters(server.Profile) + serverParameters, _, err := toc.GetParameterByName(server.Profile) Review comment: This should be using `toc.GetParametersByProfileName` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services