mhoppa commented on a change in pull request #4394: TP: adds configurability 
(show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378935342
 
 

 ##########
 File path: 
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
 ##########
 @@ -48,7 +60,6 @@
                 <td data-search="^{{::p.configFile}}$">{{::p.configFile}}</td>
                 <td data-search="^{{::p.value}}$">{{::p.value}}</td>
                 <td data-search="^{{::p.secure}}$">{{::p.secure}}</td>
-                <td><button type="button" class="btn btn-link" title="Unlink 
Parameter from Cache Group" ng-click="removeParameter(p.id)"><i class="fa 
fa-chain-broken"></i></button></td>
 
 Review comment:
   why the removal of this? I think it was the easiest way to remove 
associations without the need to right click or search through the big list 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to