mitchell852 commented on a change in pull request #4394: TP: adds
configurability (show/hide columns) to the parameters and users tables
URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378982102
##########
File path:
traffic_portal/app/src/common/modules/table/cacheGroupParameters/table.cacheGroupParameters.tpl.html
##########
@@ -48,7 +60,6 @@
<td data-search="^{{::p.configFile}}$">{{::p.configFile}}</td>
<td data-search="^{{::p.value}}$">{{::p.value}}</td>
<td data-search="^{{::p.secure}}$">{{::p.secure}}</td>
- <td><button type="button" class="btn btn-link" title="Unlink
Parameter from Cache Group" ng-click="removeParameter(p.id)"><i class="fa
fa-chain-broken"></i></button></td>
Review comment:
this is kind of a "fake" column. it doesn't map to a property of a
"parameter" so it makes things messy when defining columns in a dynamic and
configurable way. i.e.
```
"columns": [
{ "name": "Name", "visible": true,
"searchable": true },
{ "name": "Config File", "visible": true,
"searchable": true },
{ "name": "Value", "visible": true,
"searchable": true },
{ "name": "Secure", "visible": true,
"searchable": true }
],
```
so rather than deal with it, i just removed it. you can still remove a param
from a cg using the "context menu" (right click)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
