rawlinp commented on a change in pull request #4734:
URL: https://github.com/apache/trafficcontrol/pull/4734#discussion_r433436471
##########
File path: docs/source/api/v3/steering_id_targets.rst
##########
@@ -148,9 +148,9 @@ Response Structure
:deliveryServiceId: An integral, unique identifier for the steering
:term:`Delivery Service`
:target: A string that is the :ref:`ds-xmlid` of this target
:term:`Delivery Service`
:targetId: An integral, unique identifier for this target
:term:`Delivery Service`
-:type: The routing type of this target :term:`Delivery Service`
+:type: The steering type of this target :term:`Delivery Service`.
This should be one of ``STEERING_WEIGHT``, ``STEERING_ORDER``,
``STEERING_GEO_ORDER`` or ``STEERING_GEO_WEIGHT``
:typeId: An integral, unique identifier for the :ref:`routing type
<ds-types>` of this target :term:`Delivery Service`
Review comment:
This should also be changed to say "steering type"
##########
File path: docs/source/api/v3/steering_id_targets_targetID.rst
##########
@@ -64,7 +64,7 @@ Response Structure
:deliveryServiceId: An integral, unique identifier for the steering
:term:`Delivery Service`
:target: A string that is the :ref:`ds-xmlid` of this target
:term:`Delivery Service`
:targetId: An integral, unique identifier for this target
:term:`Delivery Service`
-:type: The routing type of this target :term:`Delivery Service`
+:type: The steering type of this target :term:`Delivery Service`
:typeId: An integral, unique identifier for the :ref:`routing type
<ds-types>` of this target :term:`Delivery Service`
Review comment:
This should also be changed to say "steering type"
##########
File path: traffic_ops/traffic_ops_golang/steeringtargets/steeringtargets.go
##########
@@ -160,6 +160,10 @@ func read(tx *sqlx.Tx, parameters map[string]string, user
*auth.CurrentUser) ([]
}
func (st *TOSteeringTargetV11) Create() (error, error, int) {
+ valid, err := tc.ValidateTypeID(st.ReqInfo.Tx.Tx, st.TypeID,
"steering_target")
Review comment:
This validation should live in `lib/go-tc/steeringtarget.go:Validate()`
-- same w/ the `Update` validation below. Putting it there should cover both
cases.
##########
File path: docs/source/api/v3/steering_id_targets.rst
##########
@@ -72,9 +72,9 @@ Response Structure
:deliveryServiceId: An integral, unique identifier for the steering
:term:`Delivery Service`
:target: A string that is the :ref:`ds-xmlid` of this target
:term:`Delivery Service`
:targetId: An integral, unique identifier for this target
:term:`Delivery Service`
-:type: The routing type of this target :term:`Delivery Service`
+:type: The steering type of this target :term:`Delivery Service`.
This should be one of ``STEERING_WEIGHT``, ``STEERING_ORDER``,
``STEERING_GEO_ORDER`` or ``STEERING_GEO_WEIGHT``
:typeId: An integral, unique identifier for the :ref:`routing type
<ds-types>` of this target :term:`Delivery Service`
Review comment:
This should also be changed to say "steering type"
##########
File path: docs/source/api/v3/steering_id_targets.rst
##########
@@ -122,8 +122,8 @@ Request Structure
+------+---------------------------------------------------------------------------------------------------------+
:targetId: The integral, unique identifier of a :term:`Delivery Service` which
shall be a new steering target for the :term:`Delivery Service` identified by
the ``ID`` path parameter
-:typeId: The integral, unique identifier of the routing type of the new
target :term:`Delivery Service`
-:value: The 'weight' which shall be attributed to the new target
:term:`Delivery Service`
+:typeId: The integral, unique identifier of the routing type of the new
target :term:`Delivery Service`. This should be corresponding to one of
``STEERING_WEIGHT``, ``STEERING_ORDER``, ``STEERING_GEO_ORDER`` or
``STEERING_GEO_WEIGHT``
Review comment:
☝️ this isn't resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
