rawlinp commented on a change in pull request #4734:
URL: https://github.com/apache/trafficcontrol/pull/4734#discussion_r433511252



##########
File path: traffic_ops/traffic_ops_golang/steeringtargets/steeringtargets.go
##########
@@ -160,6 +160,10 @@ func read(tx *sqlx.Tx, parameters map[string]string, user 
*auth.CurrentUser) ([]
 }
 
 func (st *TOSteeringTargetV11) Create() (error, error, int) {
+       err := st.Validate()

Review comment:
       So the `Validate` method does not need to be called directly here and 
below, because it gets called by the `api.CreateHandler` and 
`api.UpdateHandler` methods via `decodeAndValidateRequestBody` in 
api/shared_handlers.go. By the time the `Create`/`Update` method is called on 
this object, its `Validate` method has already been called.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to