ocket8888 commented on pull request #4700: URL: https://github.com/apache/trafficcontrol/pull/4700#issuecomment-641505912
I think the problem was that I misunderstood what was meant by "feature branch" initially. I think you mean "feature branch" to say "a branch of apache/trafficcontrol that contains the entire body of work necessary to implement servers having multiple interfaces in every facet of every component" whereas I mean "A big branch of changes across multiple components that provides all of the changes necessary to implement a feature - which may or may not mean everything it takes to implement servers having multiple interfaces." For example, you did a feature branch with topologies. You don't call it a feature branch, but I would, because it was a branch that encapsulated a feature - the feature of including and being able to manipulate ATC topologies. Just because it didn't totally fulfil the requirements of a blueprint doesn't make it not a feature branch, IMO. To be clear I'm not against using a "feature branch" by either of those definitions. I just thought they were frowned upon equally, so I tried to do things without them. Imagine my surprise when a Topologies feature branch sprung up. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
