rawlinp commented on pull request #4700: URL: https://github.com/apache/trafficcontrol/pull/4700#issuecomment-641525620
There was no feature branch for Topologies -- all the work we've done on Topologies so far has been made in atomic PRs to master. Our definition of feature branches is the same. I'm not specifying "within this repo" either. Everyone creates a "feature branch" in their own forks in order to create a PR. Every PR to master essentially _is_ a feature branch. At the end of the day, I don't think we should ever be opening massive PRs that take a tremendous amount of time in one sitting to review/test/merge. Most new features can always be broken down into smaller, atomic PRs that don't break things when merged on their own. Throughout reviewing this PR, I've tried to describe to you _how_ that could've been done from the get-go, so that we can try to break things down into smaller, atomic PRs in the future. Creating a feature branch goes entirely against that idea, because it means reviewing and merging one massive PR into master that completely implements an entire new feature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
