rob05c commented on a change in pull request #4790:
URL: https://github.com/apache/trafficcontrol/pull/4790#discussion_r451688568
##########
File path: lib/go-atscfg/hostingdotconfig.go
##########
@@ -74,3 +92,22 @@ func MakeHostingDotConfig(
text += strings.Join(lines, "")
return text
}
+
+func hostingMakeDSTopologies(dses []tc.DeliveryServiceNullable, topologies
[]tc.Topology) map[tc.DeliveryServiceName]tc.Topology {
Review comment:
Not without a function to translate `RemapConfigDSData` to
`DeliveryServiceNullable`, which would be even more code.
The non-API types like `RemapConfigDSData` exist in order to reduce
duplication and unnecessary queries in TO. I'd like to remove them and change
all the `atscfg` funcs to take standard API objects, but I was waiting until
the config files were removed from the TO API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
