rob05c commented on a change in pull request #4790:
URL: https://github.com/apache/trafficcontrol/pull/4790#discussion_r451710180
##########
File path: traffic_ops_ort/atstccfg/cfgfile/headerrewritedotconfig.go
##########
@@ -70,7 +70,7 @@ func GetConfigFileCDNHeaderRewrite(toData *config.TOData,
fileName string) (stri
if server.CDNName != *tcDS.CDNName {
continue
}
- if _, ok := dsServerIDs[server.ID]; !ok {
+ if _, ok := dsServerIDs[server.ID]; !ok && tcDS.Topology == nil
{
Review comment:
Probably, but yeah, not critical.
Header rewrites are their own file, so the place to do that is the meta gen.
The `assignedEdges` here are only used to calculate Max Origin Connections.
The change here is just saying "if the DS is in a Topology, include the Edge in
the Assigned count for MaxOriginConns."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
