bdgranger opened a new issue #4894: URL: https://github.com/apache/trafficcontrol/issues/4894
<!-- ************ STOP!! ************ If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact the Apache Software Foundation Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. --> <!-- - For *SUPPORT QUESTIONS*, use the [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/). - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. --> ## I'm submitting a ... <!-- (check all that apply with "[x]") --> <!--- security vulnerability (STOP!! - see above)--> - [x] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability, performance, tech debt, etc.) - [ ] other <!--(Please do not submit support requests here - see above)--> ## Traffic Control components affected ... <!-- (check all that apply with "[x]") --> - [ ] CDN in a Box - [ ] Documentation - [ ] Grove - [ ] Traffic Control Client - [ ] Traffic Monitor - [x] Traffic Ops - [ ] Traffic Ops ORT - [ ] Traffic Portal - [ ] Traffic Router - [ ] Traffic Stats - [ ] Traffic Vault - [ ] unknown ## Current behavior: <!-- Describe how the bug manifests / how the current features are insufficient. --> ATC version 3.1.0, running on Centos7.7. I am running multiple ATS caches on a single server in docker containers, so need to assign each container cache different tcpPort and httpsPort in order to avoid conflicts (e.g. instance 1: docker -p 10000:80 -p 11000:443; instance 2: docker -p 10002:80 -p 11002:443). I can create multiple servers through traffic ops using the same IP address but different ports. When generating the remap.config lines for a "http and https" delivery service, traffic ops appends the tcpPort to the domain of the http line, but does not append the httpsPort to the domain in the https line. Sample remap.config output: **# DO NOT EDIT - Generated for bg-vedge by Traffic Ops (https://bg-cdn-to.bg-cdn.com) on Fri Jun 26 15:49:20 UTC 2020 map http://bg-vedge.bgvirt.content.bg-cdn.com:10000/ http://www.google.com/ @plugin=header_rewrite.so @pparam=dscp/set_dscp_0.config map https://bg-vedge.bgvirt.content.bg-cdn.com/ http://www.google.com/ @plugin=header_rewrite.so @pparam=dscp/set_dscp_0.config** The result is that if I attempt to fetch content through the https URL using the non-standard port, I get a "not found on server" response since no line in remap.config matches "https://bg-vedge.bgvirt.content.bg-cdn.com:11000";, which is the URL I have to use to connect to that edge cache container. ## Expected / new behavior: <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control --> I would expect the https remap line to have the non-standard httpsPort appended to the domain, in the same way that the http line has the non-standard tcpPort appended. ## Minimal reproduction of the problem with instructions: <!-- If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the *STEPS TO REPRODUCE* and include the applicable TC version. --> No actual caches needed to reproduce this issue, it can all be seen using only the traffic ops UI. * Create a new edge server in the traffic ops UI, using non-standard tcpPort and httpsPort (e.g. 10000, 11000) * Create an "http and https" delivery service and assign the newly-created server to it * Under the servers tab, select "edit" for the newly-created server, then select "Get Config Files" * Look under remap.config and see that the http line includes the tcpPort but the https line does not include the httpsPort ## Anything else: <!-- e.g. stacktraces, related issues, suggestions how to fix --> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
