ocket8888 commented on a change in pull request #4934:
URL: https://github.com/apache/trafficcontrol/pull/4934#discussion_r467521334
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -58,11 +58,17 @@
</div>
<div class="form-group" ng-class="{'has-error':
hasError(dsStaticDnsEntryForm.address), 'has-feedback':
hasError(dsStaticDnsEntryForm.address)}">
<label for="address" class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12">Address *<div class="helptooltip">
- <div class="helptext">The Address Rules.<br>1.
Type:A_RECORD, Address should be an IPv4 address. <br>2. Type: AAAA_RECORD,
Address should be an IPv6 address. <br>3. Type: CNAME, Address must end with a
trailing period if type:CNAME. Eg: cdn.test.com. is correct but cdn.test.com
will not work</div>
+ <div class="helptext">The Address Rules.
+ <br>1. Type:A_RECORD, address should be an IPv4
address.
+ <br>2. Type:AAAA_RECORD, address should be an IPv6
address.
+ <br>3. Type:CNAME, address must end with a trailing
period.
+ <br>4. Type:TXT_RECORD, address cannot be blank.
Review comment:
instead of manually numbering and line-breaking, this should probably be
a list. But also, I don't think the order of the rules is important, so it
should probably be an unordered list:
```html
<div class="helptext">The Address rules:
<ul>
<li>Type:A_RECORD - address should be an IPv4 address</li>
<li>Type:AAAA_RECORD - address should be an IPv6 address.</li>
<li>Type:CNAME - address must end with a trailing period.</li>
<li>Type:TXT_RECORD - address cannot be blank.</li>
</ul>
</div>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
