mitchell852 commented on a change in pull request #4934:
URL: https://github.com/apache/trafficcontrol/pull/4934#discussion_r468655605
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -57,9 +57,20 @@
</div>
</div>
<div class="form-group" ng-class="{'has-error':
hasError(dsStaticDnsEntryForm.address), 'has-feedback':
hasError(dsStaticDnsEntryForm.address)}">
- <label for="address" class="control-label col-md-2 col-sm-2
col-xs-12">Address *</label>
+ <label for="address" class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12">Address *<div class="helptooltip">
+ <div class="helptext">The Address Rules.
+ <ul>
+ <li>Type:A_RECORD, address should be an IPv4
address.</li>
+ <li>Type:AAAA_RECORD, address should be an IPv6
address.</li>
+ <li>Type:CNAME, address must end with a trailing
period.</li>
Review comment:
can you change this to:
`Type:CNAME, address must be a valid DNS name ending with a trailing period.
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -57,9 +57,20 @@
</div>
</div>
<div class="form-group" ng-class="{'has-error':
hasError(dsStaticDnsEntryForm.address), 'has-feedback':
hasError(dsStaticDnsEntryForm.address)}">
- <label for="address" class="control-label col-md-2 col-sm-2
col-xs-12">Address *</label>
+ <label for="address" class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12">Address *<div class="helptooltip">
+ <div class="helptext">The Address Rules.
+ <ul>
+ <li>Type:A_RECORD, address should be an IPv4
address.</li>
+ <li>Type:AAAA_RECORD, address should be an IPv6
address.</li>
+ <li>Type:CNAME, address must end with a trailing
period.</li>
+ <li>Type:TXT_RECORD, address cannot be blank.</li>
+ </ul>
+ </div>
+ </div>
+ </label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="address" name="address" type="text"
class="form-control" ng-model="staticDnsEntry.address" required>
+ <input id="address" name="address" type="text"
class="form-control" ng-model="staticDnsEntry.address"
+ required title= "Address must be: an IPv4, if
type:A_RECORD; an IPv6, if type: AAAA_RECORD; end with a trailing period if
type:CNAME_RECORD; cannot be blank; if type: TXT_RECORD">
Review comment:
and update it. here too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
