mitchell852 commented on a change in pull request #4934:
URL: https://github.com/apache/trafficcontrol/pull/4934#discussion_r467170690
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -57,9 +57,12 @@
</div>
</div>
<div class="form-group" ng-class="{'has-error':
hasError(dsStaticDnsEntryForm.address), 'has-feedback':
hasError(dsStaticDnsEntryForm.address)}">
- <label for="address" class="control-label col-md-2 col-sm-2
col-xs-12">Address *</label>
+ <label for="address" class="has-tooltip control-label col-md-2
col-sm-2 col-xs-12">Address *<div class="helptooltip">
+ <div class="helptext">The Address Rules.<br>1.
Type:A_RECORD, Address should be an IPv4 address. <br>2. Type: AAAA_RECORD,
Address should be an IPv6 address. <br>3. Type: CNAME, Address must end with a
trailing period if type:CNAME. Eg: cdn.test.com. is correct but cdn.test.com
will not work</div>
Review comment:
this description seems a little redundant:
`Type: CNAME, Address must end with a trailing period if type:CNAME` also it
doesn't describe the valid dns part. how about:
`Type: CNAME, Address must be a valid DNS name with a trailing period`
not even sure you need the example tbh.
also, that div line is pretty long. want to break it up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
