zrhoffman commented on a change in pull request #4972:
URL: https://github.com/apache/trafficcontrol/pull/4972#discussion_r473307615



##########
File path: infrastructure/cdn-in-a-box/edge/Dockerfile
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       `edge` and `mid` are split now in 884ea728cb because GitHub Actions 
apparently doesn't support single-file bind mounts.
   
   In order to do that, `edge`'s `/opt/init.d/99-run.sh` came from 
`edge/run.sh` and `mid`'s `/opt/init.d/99-run.sh` came from `mid/run.sh`, so, 
without attempting to reconcile those 2 scripts, it just meant 2 separate 
images.
   
   The
   
   ```dockerfile
   COPY infrastructure/cdn-in-a-box/edge/init.d/ /opt/init.d/
   ```
   
   layer is essentially at the end of the Dockerfiles anyway, so the other 
layers are still cached.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to