zrhoffman commented on a change in pull request #4972: URL: https://github.com/apache/trafficcontrol/pull/4972#discussion_r473315316
########## File path: .github/actions/build-rpms/main.js ########## @@ -0,0 +1,37 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +const child_process = require("child_process"); +const spawnArgs = { + stdio: "inherit", + stderr: "inherit", +}; + +let atcComponent = process.env.ATC_COMPONENT; +const dockerComposeArgs = ["-f", `${process.env.GITHUB_WORKSPACE}/infrastructure/docker/build/docker-compose.yml`, "run", "--rm"]; +if (typeof atcComponent !== "string" || atcComponent.length === 0) { + console.error("Missing environment variable ATC_COMPONENT"); + process.exit(1); +} +const nonRpmComponents = ["source", "weasel", "docs"]; Review comment: The workflow wasn't running Weasel, but removing that check for `_build` sounds fine to me. Let's address docs in a different PR. Removed docs and source tarball from the workflow in 9398ab696.  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
