zrhoffman commented on a change in pull request #4966:
URL: https://github.com/apache/trafficcontrol/pull/4966#discussion_r478482947
##########
File path: docs/source/api/v3/servers.rst
##########
@@ -36,7 +36,9 @@ Request Structure
+============+==========+===================================================================================================================+
| cachegroup | no | Return only those servers within the
:term:`Cache Group` that has this :ref:`cache-group-id` |
+------------+----------+-------------------------------------------------------------------------------------------------------------------+
- | dsId | no | Return only those servers assigned to the
:term:`Delivery Service` identified by this integral, unique identifier |
+ | dsId | no | Return only those servers assigned to the
:term:`Delivery Service` identified by this integral, unique identifier.|
+ | | no | If the Delivery Service has a :term:`
Topology` assigned to it, the :ref:`to-api-servers` endpoint will return |
+ | | no | each server whose :ref:`Cache Group` is
associated with a :term:`Topology Node` of that Topology. |
Review comment:
Changed to `:term:` role in 8d86b6dab8
##########
File path: docs/source/glossary.rst
##########
@@ -422,6 +422,14 @@ Glossary
Tenancies
Users are grouped into :dfn:`Tenants` (or :dfn:`Tenancies`) to
segregate ownership of and permissions over :term:`Delivery Services` and their
resources. To be clear, the notion of :dfn:`Tenancy` **only** applies within
the context of :term:`Delivery Services` and does **not** apply permissions
restrictions to any other aspect of Traffic Control.
+ Topology Node
+ Topology Nodes
+ Parent Topology Node
+ Parent Topology Nodes
+ Child Topology Node
+ Child Topology Nodes
+ Each :term:`Topology Node` is associated with a particular
:term:`Cache Group`. In addition, the Topology Node has 0, 1, or 2 Parent
Topology Nodes and has 0, 1, or 2 Child Topology Nodes, according to your
configuration.
Review comment:
Using `:dfn:` role in b17101fc3e
##########
File path: traffic_ops/testing/api/v3/servers_test.go
##########
@@ -181,6 +181,36 @@ func GetTestServersQueryParameters(t *testing.T) {
t.Errorf("Expected a status code of 304, got %v",
reqInf.StatusCode)
}
+ foundTopDs := false
+ const topDsXmlId = "ds-top"
+ for _, ds := range dses {
Review comment:
Unshadowed in db1ac6c739
##########
File path: traffic_ops/testing/api/v3/servers_test.go
##########
@@ -181,6 +181,36 @@ func GetTestServersQueryParameters(t *testing.T) {
t.Errorf("Expected a status code of 304, got %v",
reqInf.StatusCode)
}
+ foundTopDs := false
+ const topDsXmlId = "ds-top"
+ for _, ds := range dses {
+ if (*ds.XMLID != topDsXmlId) {
Review comment:
Added nil check in 0c9ff12fa0
##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -650,10 +673,15 @@ func getServers(h http.Header, params map[string]string,
tx *sqlx.Tx, user *auth
if userErr != nil || sysErr != nil {
return nil, 0, errors.New("Forbidden"), sysErr,
http.StatusForbidden, nil
}
+
+ var joinSubQuery string
+ if version.Major >= 3 {
Review comment:
Added null checks to calling functions and changed the function
signature to accept a non-pointer version in da586b6805.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
