ocket8888 commented on a change in pull request #4966:
URL: https://github.com/apache/trafficcontrol/pull/4966#discussion_r481786719
##########
File path: docs/source/api/v3/servers.rst
##########
@@ -36,7 +36,9 @@ Request Structure
+============+==========+===================================================================================================================+
| cachegroup | no | Return only those servers within the
:term:`Cache Group` that has this :ref:`cache-group-id` |
+------------+----------+-------------------------------------------------------------------------------------------------------------------+
- | dsId | no | Return only those servers assigned to the
:term:`Delivery Service` identified by this integral, unique identifier |
+ | dsId | no | Return only those servers assigned to the
:term:`Delivery Service` identified by this integral, unique identifier.|
+ | | no | If the Delivery Service has a
:term:`Topology` assigned to it, the :ref:`to-api-servers` endpoint will return
|
Review comment:
Table is malformed because of misaligned <kbd>|</kbd>s on this line.
##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -650,10 +695,27 @@ func getServers(h http.Header, params map[string]string,
tx *sqlx.Tx, user *auth
if userErr != nil || sysErr != nil {
return nil, 0, errors.New("Forbidden"), sysErr,
http.StatusForbidden, nil
}
+
+ var joinSubQuery string
+ if version.Major >= 3 {
+ const hasRequiredCapabilitiesQuery = `
+SELECT EXISTS(
Review comment:
Would you mind indenting this consistent with its containing block? It's
not required by `go fmt` and it's fine syntactically as-is, but it breaks some
text editors' code folding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
