ocket8888 commented on a change in pull request #5084:
URL: https://github.com/apache/trafficcontrol/pull/5084#discussion_r497624231
##########
File path: traffic_ops/traffic_ops_golang/federations/ds.go
##########
@@ -46,7 +45,7 @@ func PostDSes(w http.ResponseWriter, r *http.Request) {
fedID := inf.IntParams["id"]
fedName, ok, err := getFedNameByID(inf.Tx.Tx, fedID)
if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError,
nil, errors.New("getting federation cname from ID '"+string(fedID)+"':
"+err.Error()))
+ api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError,
nil, errors.New("getting federation cname from ID '"+strconv.Itoa(fedID)+"':
"+err.Error()))
Review comment:
it's already being done elsewhere in the file and handler, and I'd
expect the bottleneck in the handler to be network ops like reaching out to the
database - but I haven't measured.
I guess it doesn't matter, but `string + strconv.Itoa + string +
err.Error()` is real ugly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
