rob05c commented on a change in pull request #5084:
URL: https://github.com/apache/trafficcontrol/pull/5084#discussion_r497639281
##########
File path: traffic_ops/traffic_ops_golang/federations/ds.go
##########
@@ -46,7 +45,7 @@ func PostDSes(w http.ResponseWriter, r *http.Request) {
fedID := inf.IntParams["id"]
fedName, ok, err := getFedNameByID(inf.Tx.Tx, fedID)
if err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError,
nil, errors.New("getting federation cname from ID '"+string(fedID)+"':
"+err.Error()))
+ api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError,
nil, errors.New("getting federation cname from ID '"+strconv.Itoa(fedID)+"':
"+err.Error()))
Review comment:
I agree. It makes me sad Go format strings are slow, they're so much
cleaner.
To be clear, I'm not an outright -1 here since the performance shouldn't
matter, just giving my 2ยข.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
