ocket8888 commented on a change in pull request #5252:
URL: https://github.com/apache/trafficcontrol/pull/5252#discussion_r524716553
##########
File path: infrastructure/cdn-in-a-box/edge/Dockerfile
##########
@@ -18,21 +18,98 @@
############################################################
# Dockerfile to build Edge-Tier Cache container images for
# Apache Traffic Control
-# Based on CentOS 7.2
+# Based on CentOS 8
############################################################
-FROM centos:7 AS common-cache-server-layers
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} AS common-cache-server-layers
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go
##########
@@ -17,18 +17,31 @@
############################################################
# Dockerfile to build Traffic Ops container images
-# Based on CentOS 7.2
+# Based on CentOS 8
############################################################
# Keep the trafficops-common-deps in Dockerfile-go the same
# as trafficops-common-deps in Dockerfile to cache the same
# layer.
-FROM centos:7 as trafficops-common-deps
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} as trafficops-common-deps
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/mid/Dockerfile
##########
@@ -18,21 +18,98 @@
############################################################
# Dockerfile to build Edge-Tier Cache container images for
# Apache Traffic Control
-# Based on CentOS 7.2
+# Based on CentOS 8
############################################################
-FROM centos:7 AS common-cache-server-layers
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} AS common-cache-server-layers
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_monitor/Dockerfile
##########
@@ -19,13 +19,19 @@
# Based on CentOS
############################################################
-FROM centos/systemd
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile
##########
@@ -17,18 +17,33 @@
############################################################
# Dockerfile to build Traffic Ops container images
-# Based on CentOS 7.2
+# Based on CentOS 8
############################################################
# Keep the trafficops-common-deps in Dockerfile the same as
# trafficops-common-deps in Dockerfile-go to cache the same
# layer.
-FROM centos:7 as trafficops-common-deps
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} as trafficops-common-deps
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/optional/socksproxy/Dockerfile
##########
@@ -17,13 +17,19 @@
############################################################
# Dockerfile to build optional CiaB Socks Proxy
-# Based on CentOS 7
+# Based on CentOS 8
############################################################
-FROM centos:7
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/optional/vnc/Dockerfile
##########
@@ -14,15 +14,22 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-FROM docker.io/centos:7
+
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path:
infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile
##########
@@ -15,21 +15,34 @@
# specific language governing permissions and limitations
# under the License.
-FROM centos:7 as os-dependencies
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} as os-dependencies
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_monitor/Dockerfile-debug
##########
@@ -20,10 +20,17 @@
# Based on CentOS
############################################################
-FROM centos/systemd as build-delve
-RUN yum -y install epel-release && \
- yum -y install golang && \
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} as get-delve
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go-debug
##########
@@ -17,12 +17,19 @@
############################################################
# Dockerfile to build Traffic Ops debugging container image
-# Based on CentOS 7.2
+# Based on CentOS 8
############################################################
-FROM centos:7 as get-delve
-RUN yum -y install epel-release && \
- yum -y install golang && \
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} as get-delve
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_portal/Dockerfile
##########
@@ -17,10 +17,16 @@
############################################################
# Dockerfile to build Traffic Portal container images
-# Based on CentOS 7.2
+# Based on CentOS 8
############################################################
-FROM centos:7
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_stats/Dockerfile
##########
@@ -19,20 +19,26 @@
# Based on CentOS
############################################################
-FROM centos:7
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_stats/Dockerfile-debug
##########
@@ -20,10 +20,17 @@
# Based on CentOS
############################################################
-FROM centos/systemd as build-delve
-RUN yum -y install epel-release && \
- yum -y install golang && \
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION} as get-delve
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
##########
File path: infrastructure/cdn-in-a-box/traffic_router/Dockerfile
##########
@@ -16,22 +16,29 @@
# under the License.
############################################################
# Dockerfile to build Traffic Router 3.0
-# Based on CentOS 7.x
+# Based on CentOS 8
############################################################
-FROM centos:7
+ARG CENTOS_VERSION=8
+FROM centos:${CENTOS_VERSION}
+ARG CENTOS_VERSION=8
Review comment:
duplicate ARG
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
